Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated command with environment file #617

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Replace deprecated command with environment file #617

merged 1 commit into from
Oct 18, 2023

Conversation

jongwooo
Copy link
Contributor

Description

Update workflows to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow files that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

echo ::set-output name=BRANCH::$(echo ${BRANCH} | cut -d '.' -f1-2 | tr -d 'v')

TO-BE

echo "BRANCH=$(echo ${BRANCH} | cut -d '.' -f1-2 | tr -d 'v')" >> $GITHUB_OUTPUT

Related Issues

Closes #616

How Has This Been Tested?

None

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@jongwooo jongwooo requested a review from a team as a code owner August 13, 2023 07:46
@gigerdo
Copy link
Member

gigerdo commented Oct 18, 2023

@jongwooo Thanks for opening this PR. However to be able to merge this PR, each commit must be signed according to this guide: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@jongwooo
Copy link
Contributor Author

@gigerdo Thanks for letting me know. I signed the commit.

@gigerdo gigerdo merged commit fd37558 into elastic:master Oct 18, 2023
1 check passed
@gigerdo
Copy link
Member

gigerdo commented Oct 18, 2023

Thanks @jongwooo 🙇

@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch October 18, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
3 participants