Update workflows #626
Merged
Update workflows #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigerdo
force-pushed
the
update-workflows
branch
from
20cf1ab to
0d7e303
Compare
- Remove the workflow to format&commit code on master. The PR workflow already validates that the formatting is correct. - Remove `go vet`, this is actually already part of `golangci-lint` so the call is redundant - Update issue templates, removed `Team:Delivery` as the repos are not maintained by delivery anymore.
gigerdo
force-pushed
the
update-workflows
branch
2 times, most recently
from
499edb0 to
72420a9
Compare
Newer versions of `go-licenser` don't generate the NOTICE anymore.
dimuon
reviewed
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few updates to the
ecctl github workflows/actions:Team:Deliverylabels as they are not relevant anymoreon_master_generation.ymlworkflow: This used to update the NOTICE and push it to master. Instead, the PR verification now checks that NOTICE is up-to-date so this workflow is not needed.go-licence-detectorfor NOTICE generation, sincego-licenserdoesn't generate the NOTICE anymore in newer versions.Description
Related Issues
Motivation and Context
How Has This Been Tested?
Types of Changes
Readiness Checklist