Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all service definition in formulae #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laggardkernel
Copy link
Contributor

@laggardkernel laggardkernel commented Sep 7, 2023

Replace all plist definitions with the new service definitions. plist_options :manual is removed, cuz the service block will generated the manual start instruction automatically.

brew info elasticsearch-full

...

To start elastic/tap/elasticsearch-full now and restart at login:
  brew services start elastic/tap/elasticsearch-full
Or, if you don't want/need a background service you can just run:
  /usr/local/opt/elasticsearch-full/bin/elasticsearch    # this is auto generated

ref

@laggardkernel
Copy link
Contributor Author

laggardkernel commented Sep 27, 2023

Any reviews?

The obsolete plist definitions make the tap unusable cuz brew stops recognizing the formulae syntax valid. Install and update with brew just fails now.

@pavrda
Copy link

pavrda commented Oct 19, 2024

Thank you for your work on this pull request. Even though it wasn't merged, it has been really helpful to me and many others. Your contribution made a positive impact, and I appreciate the effort you put into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants