Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

"Caching" of builds is not working #68

Open
madsnedergaard opened this issue Oct 19, 2020 · 3 comments · Fixed by #70
Open

"Caching" of builds is not working #68

madsnedergaard opened this issue Oct 19, 2020 · 3 comments · Fixed by #70
Labels
bug Something isn't working

Comments

@madsnedergaard
Copy link
Member

madsnedergaard commented Oct 19, 2020

Seems like it's broken again for some reason..
Haven't dived too deep into it, but as far as I can tell, it finds images with same dependency-hash yet still builds all packages :(

See example from CI here: https://drone.tmrow.com/tmrowco/bloom/107/1/3

@madsnedergaard madsnedergaard added the bug Something isn't working label Oct 19, 2020
@madsnedergaard
Copy link
Member Author

cc @skovhus (I know you're busy this week and I think we can manage for now, just thought you should know)

@skovhus
Copy link
Contributor

skovhus commented Oct 19, 2020

Thanks @madsnedergaard. It seems like it didn't find any images tagged with master... Currently we do not cache based on branch images – although we could probably do this. 🤔

It might be related to our tagging with the sha on master images, that takes over the master tag.

@skovhus
Copy link
Contributor

skovhus commented Oct 28, 2020

On a branch called ks/update-invalid-logs it failed to use the cache:

2020-10-28 12:58:33,218 [INFO] 🔨 Building northapp..
--
34 |  
35 | 2020-10-28 12:58:34,399 [DEBUG] Found 2 image(s) matching dependency hash sha256:ad3e331a72585bc9be9f2b7ca6a1975fee977f596fcbc813e680b550eb8942b0/69775997eba46e30341ab1fcfb206fa9140bb3a0 (['northapp:ks-update-invalid-logs', 'northapp_build:ks-update-invalid-logs']..)
36 | 2020-10-28 12:58:34,402 [DEBUG] docker build . --iidfile /tmp/tmpcf95z2a5 -f

@skovhus skovhus reopened this Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants