Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Add integration test setup and examples folder #69

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

skovhus
Copy link
Contributor

@skovhus skovhus commented Oct 26, 2020

#68

When fixing a caching issue in the promotion of images, I decided to wrap up some old integrations tests I started on a while ago. Manually testing Brick is very tedious, so a few high level integrations tests really helps here.

We are testing on a fairly high level:

  • asserting which docker images was found on the system
  • asserting which docker images was built (based on the log for now)
  • asserting which docker images were promoted (based on the logs for now)
  • a few additional asserts on the log output from Brick

We test several scenarios here:

  • build a single workspace on master
  • rebuilt a single workspace on master (caching)
  • rebuilt a single workspace on a new branch (promoting)
  • building a workspace
  • testing a workspace

Note that one of them is currently skip due to a bug in promoting images.
@corradio
Copy link
Member

corradio commented Oct 27, 2020

I'll let @madsnedergaard review if that's fine with you.
Thanks for cc'ing me though!

@corradio corradio removed their request for review October 27, 2020 10:26
Copy link
Member

@madsnedergaard madsnedergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@madsnedergaard
Copy link
Member

Started reviewing yesterday, but thought I was hitting an infinite loop when running the test since my CPU was going crazy for so long - turns out it just need more time 😄

@skovhus
Copy link
Contributor Author

skovhus commented Oct 27, 2020

Started reviewing yesterday, but thought I was hitting an infinite loop when running the test since my CPU was going crazy for so long - turns out it just need more time 😄

Wow! They take 40 seconds on CI... Wondering if something else was wrong 🤔

@skovhus skovhus merged commit 94e7aef into master Oct 27, 2020
@skovhus skovhus deleted the ks/integration-testing branch October 27, 2020 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants