Mobile app CI build and deploy #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixDQ
approved these changes
Jan 6, 2021
| @@ -11,7 +11,7 @@ steps: | |||
|
|
|||
| build: | |||
| environment: | |||
| ELECTRICITYMAP_PUBLIC_TOKEN: ${BRICK_ELECTRICITYMAP_PUBLIC_TOKEN} | |||
| ELECTRICITYMAP_PUBLIC_TOKEN: ${BRICK_ELECTRICITYMAP_PUBLIC_TOKEN:-unknown} | |||
There was a problem hiding this comment.
it's a fallback value for when the env variable is not defined.
It's due to electricitymaps/brick#79
con-cat
pushed a commit
to con-cat/electricitymap-contrib
that referenced
this pull request
May 18, 2021
* Deploy electricityMap static assets to GCS * update dockerfile paths * Revert * Fix dockerfile * Add config * update container path * Mobile app CI build and deploy * Show app version on mobile info tab * lint * restore build.sh * update * Add staging * Add promote stage * Final * Req changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for continuously deploying the cordova app in our CI.
@FelixDQ @Kongkille FYI
Outstanding tasks:
Now also shows current app version (when it's on mobile):
