Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(init): remove unmaintained resolve-package #3812

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Jan 20, 2025

This PR removes the unmaintained resolve-package module in favour of using resolve.require directly for global modules.

Uses global-dirs to fetch the cross-platform values of npm root --global and yarn global dir without shelling out to a child process.

Note: we can't use await import for ESM-only moules in Forge at the moment because of our tsconfig.json values, so we're using global-dirs in this PR instead of the newer global-directory package.

@erickzhao erickzhao marked this pull request as ready for review January 23, 2025 21:56
@erickzhao erickzhao requested a review from a team as a code owner January 23, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants