Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky playwright tests #28957

Merged
merged 38 commits into from
Jan 14, 2025
Merged

Fix flaky playwright tests #28957

merged 38 commits into from
Jan 14, 2025

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 10, 2025 •
edited
Loading

Fixes #28846
Fixes #27215
Fixes #28845
Fixes #27754
Fixes #28937
Fixes #27814
Fixes #28801
Fixes #27718
Fixes #27646
Fixes #28844

Before
image

After
image

@t3chguy
Docs
45607bb 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Avoid reusing user1234
1b8f62a 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Fix stale-screenshot-reporter.ts
b203e4b 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Clean up public rooms between tests on reused homeserver
3eeb221 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Deflake spotlight when homeserver is reused
b7b650e 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Deflake more tests using existing username
c25c8a3 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Clean mailhog between tests
db47e68 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy added the T-Task Tasks for the team like planning label Jan 10, 2025
@t3chguy
Fix more flakes
8f68dbb 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Fix missing _request
548d45a 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Iterate
8b3ffb4 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Iterate
71f06cd 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Iterate
1a98f8c 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Iterate
0f6f047 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Fix playwright flaky tests
ad0b86c 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy self-assigned this Jan 10, 2025
@t3chguy
Wipe mailhog between test runs
6a62ae5 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Delint
f03ad7b 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Merge branch 'develop' of https://github.com/vector-im/element-web in…
a1fc44d 
…to t3chguy/flaky-playwright-13jan

# Conflicts:
#	playwright/services.ts
@t3chguy
Merge branch 't3chguy/flaky-playwright-13jan' of https://github.com/v…
d87dff6 
…ector-im/element-web into t3chguy/flaky-tests-10jan

# Conflicts:
#	playwright/services.ts
#	playwright/testcontainers/utils.ts
Base automatically changed from t3chguy/flaky-playwright-13jan to develop January 13, 2025 17:40
@t3chguy
Merge branch 'develop' of https://github.com/vector-im/element-web in…
c7c9c9a 
…to t3chguy/flaky-tests-10jan

# Conflicts:
#	playwright/services.ts
#	playwright/testcontainers/synapse.ts
@t3chguy
Iterate
0e7c40c 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Iterate
cae93fa 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Merge branch 'develop' of https://github.com/vector-im/element-web in…
3b4ca5e 
…to t3chguy/flaky-tests-10jan

# Conflicts:
#	playwright/plugins/homeserver/synapse/legacyOAuthHomeserver.ts
#	playwright/services.ts
@t3chguy t3chguy marked this pull request as ready for review January 13, 2025 18:22
@t3chguy t3chguy requested a review from a team as a code owner January 13, 2025 18:22
@t3chguy t3chguy requested review from dbkr and MidhunSureshR January 13, 2025 18:22
@t3chguy
Merge branch 'develop' of https://github.com/vector-im/element-web in…
4ad16af 
…to t3chguy/flaky-tests-10jan

# Conflicts:
#	playwright/plugins/homeserver/synapse/legacyOAuthHomeserver.ts
#	playwright/services.ts
@t3chguy
Merge branch 'develop' of https://github.com/vector-im/element-web in…
7b69861 
…to t3chguy/flaky-tests-10jan

Signed-off-by: Michael Telatynski <[email protected]>

# Conflicts:
#	playwright/services.ts
#	playwright/testcontainers/synapse.ts
@t3chguy t3chguy added this pull request to the merge queue Jan 14, 2025
Merged via the queue into develop with commit 5882b00 Jan 14, 2025
31 checks passed
@t3chguy t3chguy deleted the t3chguy/flaky-tests-10jan branch January 14, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky playwright test: spotlight/spotlight.spec.ts: should find unknown public world readable rooms Flaky playwright test: spotlight/spotlight.spec.ts: should allow opening group chat dialog Flaky playwright test: spotlight/spotlight.spec.ts: should find known public rooms Flaky playwright test: spotlight/spotlight.spec.ts: should find group DMs by usernames or user ids Flaky playwright test: spotlight/spotlight.spec.ts: should show the same user only once
Flaky playwright test: spotlight/spotlight.spec.ts: should find unknown public rooms Flaky playwright test: spotlight/spotlight.spec.ts: should find known people Flaky playwright test: spotlight/spotlight.spec.ts: should close spotlight after starting a DM Flaky playwright test: spotlight/spotlight.spec.ts: should be able to navigate results via keyboard Flaky playwright test: spotlight/spotlight.spec.ts: should find unknown people
2 participants
@t3chguy @dbkr