Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blurred background #698

Merged
merged 13 commits into from
Feb 20, 2024
Merged

Add blurred background #698

merged 13 commits into from
Feb 20, 2024

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Feb 3, 2024

Closes #358
Closes #623

Background code was copied from Gala

@lenemter lenemter requested a review from a team February 3, 2024 11:51
@vjr
Copy link
Member

vjr commented Feb 4, 2024

I tried this branch and it works well for me, so thumbs up from my side. Hopefully this is reviewed/merged :-)

@vjr
Copy link
Member

vjr commented Feb 4, 2024

I tried this branch and it works well for me, so thumbs up from my side. Hopefully this is reviewed/merged :-)

Scratch that! This PR seems to break/interfere with the "fade in" PR #697 recently merged. I was looking at a problem on my machine (with AMD RX580 GPU on OS 7.1 daily) with the fade-in being all noise/garbled but only the wallpaper/background, the other elements (ui_group) fade-in properly. I have not yet tested with OS8 ISO.

@lenemter
Copy link
Member Author

lenemter commented Feb 5, 2024

@vjr Oops, I'll fix the fade-in animation as soon as I can

@danirabbit
Copy link
Member

@vjr since we reverted the fade in for now, does this still break for you?

@vjr
Copy link
Member

vjr commented Feb 8, 2024

@danirabbit yes the blank screen issue is still present.

I just now tested on an updated os8 install showing greeter version 7.0.0 r1550 pkg96 daily ubuntu8.1

Same issue after building and installing this branch so I don't think it was the fade-in PR so hopefully it will return in some form because it's cool.

My bad if I misguided y'all with my recent comments about the fadein causing artefacts which was occurring only on my older PC with an AMD RX 580 GPU.

@vjr
Copy link
Member

vjr commented Feb 8, 2024

Okay I just tested this branch with one change to move the Gtk.init call a few lines lower in src/Application.vala like was done in the fade in PR and it fixes the blank screen issue.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A problem this introduces is now for light wallpapers the panel becomes illegible. So we probably need to also include everything for setting the panel for light or dark and probably sync the panel transparency setting for the user as well 😅

@lenemter
Copy link
Member Author

@danirabbit I fixed panel contrast here. I'll prepare a branch for syncing the transparency setting later

@lenemter lenemter requested a review from danirabbit February 15, 2024 04:50
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so good, couple of small things:

  • It looks like the panel transition doesn't start until after the wallpaper transition completes. Is there a way to make this happen at the same time? Basically what I'm seeing is you switch cards, the wallpaper transition happens, then the panel transition happens.
  • It looks like this is being set/updated when cards are switched, but it isn't set when the greeter first loads. So if the user that is focused when the greeter starts has a light wallpaper, the icons will be white until you focus another card and then switch back

* BackgroundManager: send `changed` signal immediately

* Sync with gala
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG 🚀

@danirabbit danirabbit merged commit 8cc1282 into master Feb 20, 2024
4 checks passed
@danirabbit danirabbit deleted the lenemter/blurred-bg branch February 20, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants