Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler fade-in animation #703

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Simpler fade-in animation #703

merged 3 commits into from
Feb 13, 2024

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Feb 9, 2024

Closes #702

Uses simpler way to animate fade-in. Should not produce any glitches whatsoever.

@lenemter lenemter requested a review from a team February 9, 2024 10:28
@vjr
Copy link
Member

vjr commented Feb 9, 2024

I can test this branch and comment later tonight which is about 4 or 5 hours from now.

@vjr
Copy link
Member

vjr commented Feb 9, 2024

OK I've observed the following:

This PR works with OS 8 daily on my newer laptop (Ryzen 7840U with 780M iGPU) but not on my older desktop with an AMD RX 580 GPU - the "blank screen" issue persists - actually you can see the user cards stuck in shrunken size very faint though - and just typing password I can login. I wonder if it's something to do with Noble still being in development.

This PR works well on OS 7.1 daily on my older desktop with the AMD RX 580 GPU (where the OS 8 install has the blank screen issue). I do not have OS 7.1 daily on my laptop to test but I have another Ryzen 6800U laptop with 680M iGPU which I can install both daily ISOs of OS 7.1 and 8 and test if not tonight then over the weekend.

I think this PR is OK to merge IMHO both code and behaviour LGTM but I'll leave it to others to also review/test.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@danirabbit danirabbit merged commit 0b833ea into master Feb 13, 2024
4 checks passed
@danirabbit danirabbit deleted the lenemter/simpler-fade-in branch February 13, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants