Application: subclass Gtk.Application #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeebok
approved these changes
Jun 5, 2024
|
@zeebok can I get a re-review on this? Things have moved a little and want to verify this isn't breaking for someone else |
|
Not sure what part was breaking for you but greeter worked for me on OS8 after locking, logging out, or restarting my PC. |
|
Ah nope sorry it wasn't breaking here either, but I just wanted to make sure that it was still good and not merge a "works for me" thing 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start to set up Greeter as a Gtk.Application. Things are very fragile and I can't get the greeter window to actually launch correctly in activate, but it's movement 🤷