Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rtl): replace ellipsis span anchor content with bdi #3123

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix(rtl): replace ellipsis span anchor content with bdi #3123

merged 1 commit into from
Jan 3, 2025
+31 −7

Conversation

userquin
Copy link
Member

@userquin userquin commented Jan 2, 2025

closes #3122

@netlify Netlify
Copy link

netlify bot commented Jan 2, 2025 •
edited
Loading

✅ Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 2d495df
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/6776e99b4770bb0008491991

@netlify Netlify
Copy link

netlify bot commented Jan 2, 2025 •
edited
Loading

✅ Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 2d495df
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/6776e99be4d8050008450046
😎 Deploy Preview https://deploy-preview-3123--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

shuuji3
shuuji3 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@shuuji3 shuuji3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

image

image

@shuuji3 shuuji3 added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit e59f5db Jan 3, 2025
15 checks passed
@shuuji3 shuuji3 deleted the userquin/fix-rtl-anchor-ellipsis branch January 3, 2025 00:54
@shuuji3 shuuji3 mentioned this pull request Jan 22, 2025
Open
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuuji3 shuuji3 shuuji3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elk places ellipses on the wrong side of a truncated URL in RTL posts
2 participants
@userquin @shuuji3