Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in-browser compiler error display #2247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −0
Open

Fix in-browser compiler error display #2247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions reactor/src/Errors.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ viewError error =
, style "white-space" "pre-wrap"
, style "background-color" "black"
, style "padding" "2em"
, style "box-sizing" "border-box"
, style "width" "100%"
, style "overflow" "scroll"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this use "auto" so there’s no unnecessary scrollbar when there is no overflow?

The default on macOS is to draw scrollbars on top of content, and only show it when scrolling. By changing a system setting, you can make macOS behave like Windows and Linux, which is to let the scrollbars take space and always be visible.

The difference between scroll and auto is that if no scrolling is needed, scroll shows ugly disabled scrollbars while auto shows no scrollbars at all.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

]
(viewErrorHelp error)
]
Expand Down