Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make copy generic over map types #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

elv-nate
Copy link
Contributor

@elv-nate elv-nate commented May 6, 2024

No description provided.

@elv-nate elv-nate requested a review from elv-gilles May 6, 2024 21:01
@elv-nate elv-nate self-assigned this May 6, 2024
@lukseven
Copy link
Collaborator

lukseven commented May 7, 2024

This was already coded on the cborv2 branch here: 84a1081
We might be able to just cherry-pick that, even though I already picked some of the code in sliceutil...

@elv-nate
Copy link
Contributor Author

elv-nate commented May 7, 2024

When will cborv2 come in? If you think it'll be merged in in the upcoming few weeks or so I think it's best to just wait for that merge, as like mentioned this is nothing pressing, and that way there's no merge conflicts to consider.

Otherwise I think cherry-picking is best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants