Stream url list

[elv-zenia]

Add StreamListUrls to return a list of pre-allocated URLs and their active/inactive status.

Example response

{
  mpegts: [
    {
      url: 'udp://...',
      active: true
    },
    {
      url: 'udp://...',
      active: false
    },
    {
      url: 'udp://...',
      active: false
    },
    {
      url: 'udp://...',
      active: true
    }
  ],
  rtmp: [
    {
      url: 'rtmp://...',
      active: false
    },
    {
      url: 'rtmp://...',
      active: true
    }
  ],
  srt: [
    {
      url: 'srt://...',
      active: false
    },
    {
      url: 'srt://...',
      active: false
    }
  ]
}

[elv-serban]

The logic looks good.

Noting here that in the fabric API v2 we can replace the metadata GETs for each object with a single 'fields' query across the tenancy (so we don't need to optimize this area at the moment, in view of replacing later with the v2 query)

[elv-zenia]

Added the changes for StreamStopSession (#262)

[elv-serban]

We should create the new write token in all cases.
This is because the edge write token has a ton of metadata in it - as created by the live recorder (the list of all video and audio parts and metadata for each part, ...).

I think we should do nothing when edge_meta doesn't work.
And if it does work then we can check the status, like you already to, and then discard/delete the edge write token (though I am not sure if we have a client method to discard a write token)

Then just open the new write token in all cases and write the status fields, then finalize and publish.

[elv-zenia]

It doesn't look like there's a client method to discard a write token. Is there a contract method for this?

[elv-zenia]

@elv-serban Updated the code. The edge write token gets removed from the object's metadata; it just needs to get discarded if there's a way.

[elv-serban]

Maybe we can say 'close the edge write token ...' and make the stream object inactive.

[elv-zenia]

@elv-serban Updated to address comments. One thing I'm not sure about. The response from terminating a stream is below. Should the edge_write_token be the one found in the metadata (if found) that was deleted?

return {
      fin,
      name,
      edge_write_token: <token>,
      state: newState
    };

[elv-serban]

Looks good!

[elv-kevin]

probably cleaner to use optional chaining for this

stream?.sources?.default?.["."]?.container

[elv-zenia]

I'm hesitant to use optional chaining in client-js because I don't think all apps that use it support it. I think there are a few Webpack 4 projects

[elv-kevin]

Oh, right this is the client. Fair point, no optional chaining

[elv-kevin]

!metaEdgeWriteToken? or does it matter if it's null

[elv-zenia]

Changing

[elv-zenia]

Ok changed this

[elv-zenia]

Relates to https://github.com/qluvio/elv-apps-projects/issues/240