Add objects basic operations script and update publishContentVersion method #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elv-zenia
approved these changes
Jul 9, 2024
|
Noting the PublishContentVersion change addresses #287 |
elv-serban
requested changes
Jul 9, 2024
src/client/ContentManagement.js
Outdated
| if(awaitCommitConfirmation) { | ||
| this.Log(`Awaiting commit confirmation for ${objectHash}`); | ||
| const pollingInterval = this.ethClient.Provider().pollingInterval || 500; | ||
| const startTime = Date.now(); | ||
| const duration = 2 * 60 * 1000; // 2 minutes |
There was a problem hiding this comment.
We shouldn't use a global timeout here because object publishing times are proportional to the size of the change (a 6 hour high-res VOD object might take 10 min to publish).
I suggest we remove this timeout at this version and we could add a timeout parameter in the future if needed
There was a problem hiding this comment.
sure @elv-serban will make the changes.
elv-serban
reviewed
Jul 12, 2024
src/client/ContentManagement.js
Outdated
| @@ -1050,6 +1052,7 @@ exports.PublishContentVersion = async function({objectId, versionHash, awaitComm | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
There is an extra empty line here
src/client/ContentManagement.js
Outdated
| @@ -1006,7 +1006,8 @@ exports.PublishContentVersion = async function({objectId, versionHash, awaitComm | |||
| }); | |||
|
|
|||
| const abi = await this.ContractAbi({id: objectId}); | |||
| const fromBlock = commit.blockNumber + 1; | |||
| const fromBlock = commit.blockNumber - 10; // due to block re-org | |||
There was a problem hiding this comment.
We would like to make this 30 to cover the worst case observed (25 sec and 20 blocks).
There was a problem hiding this comment.
made the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PublishContentVersionto:VersionConfirmevents and theobject hashstarting from last 10 blocks.