Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change library group permissions #99

Merged
merged 15 commits into from
Nov 13, 2023
Merged

Change library group permissions #99

merged 15 commits into from
Nov 13, 2023

Conversation

elv-zenia
Copy link
Contributor

@elv-zenia elv-zenia commented Oct 31, 2023

Update labels:
Viewer -> View
Contributor -> Contribute
Reviewer -> Manage

Change checkbox inputs to radio inputs, making a single permission value selectable.
NOTE: Since library groups may have multiple permissions, I'm adhering to the current design of having multiple values in the metadata. When loading the permissions, the app will display the highest permission level found. If "reviewer" and "contributor" are found, it will save the "reviewer" value and display Manage. When saving, it will only save one value and delete any other existing permissions (applies to old group permissions).

Add remove button to the table of all group permissions:

  • Content Library (new)
  • Content Object (new)
  • Access Group (existing/tested)
  • Content Types (new)

Design note: The radio input is a new component in Frowser. I kept the design consistent with the checkboxes in the other Group Permissions modals.

scrnli_10_31_2023_12-09-13 PM

Relates to #80

- One value is selectable
- Update labels
Copy link
Collaborator

@elv-kevin elv-kevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks much better than the existing option

@elv-zenia
Copy link
Contributor Author

I just realized this removed the ability to delete permissions for the library group. I added a way to remove from the table just like with Access Group members/managers. This also meant removing the table row link to the Access Group page.

src/stores/Object.js Outdated Show resolved Hide resolved
@elv-zenia elv-zenia merged commit d2add8e into master Nov 13, 2023
@elv-zenia elv-zenia deleted the issue-80 branch November 13, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants