-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change library group permissions #99
Conversation
- One value is selectable - Update labels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this looks much better than the existing option
I just realized this removed the ability to delete permissions for the library group. I added a way to remove from the table just like with Access Group members/managers. This also meant removing the table row link to the Access Group page. |
Update labels:
Viewer -> View
Contributor -> Contribute
Reviewer -> Manage
Change checkbox inputs to radio inputs, making a single permission value selectable.
NOTE: Since library groups may have multiple permissions, I'm adhering to the current design of having multiple values in the metadata. When loading the permissions, the app will display the highest permission level found. If "reviewer" and "contributor" are found, it will save the "reviewer" value and display Manage. When saving, it will only save one value and delete any other existing permissions (applies to old group permissions).
Add remove button to the table of all group permissions:
Design note: The radio input is a new component in Frowser. I kept the design consistent with the checkboxes in the other Group Permissions modals.
Relates to #80