-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add script to test model loading below n_parameters threshold #1698
test: Add script to test model loading below n_parameters threshold #1698
Conversation
I think we could create a file to record whether a model load was successful, to avoid repeated loading attempts. |
Right now the main issue is disk running out of space. Looking into how not to save the weights into cache folder when loading a model. |
Also, test should skip API based models |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far. Just to clarify the intention is to move this into the tests suite?
@KennethEnevoldsen thanks, and yes. |
@KennethEnevoldsen @Samoed just pushed the latest changes, and updated the description. Would you mind reviewing and seeing if anything is unclear? I'll try to push a "test" commit to see how it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, very happy to accept this with just the changes the dependecy installations.
Thanks both for your input. Right now the test fails at the merge base step (empty list is returned). If you have some time, it would be great if you could help take a quick look there. Otherwise I plan to return to this later tomorrow. |
…nto add-model-load-test-below-n_param_threshold
I think the GitHub runner automatically merges branches during CI, so you don’t need to do it manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I think we are almost there
Co-authored-by: Kenneth Enevoldsen <[email protected]>
Co-authored-by: Kenneth Enevoldsen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Thanks again. Merging now. Note that the model loading "test" will likely require merging the target branch to get the accurate diffs. |
Fixes #1690
mteb.get_model
and output the exception (None or raw text)Checklist
make test
.make lint
.