Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model inf-retriever-v1 #1744

Merged
merged 10 commits into from
Jan 15, 2025

Conversation

SamuelYang1
Copy link
Contributor

@SamuelYang1 SamuelYang1 commented Jan 10, 2025

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

Adding a model checklist

Eval results embeddings-benchmark/results#90

  • I have filled out the ModelMeta object to the extent possible
  • I have ensured that my model can be loaded using
    • mteb.get_model(model_name, revision) and
    • mteb.get_model_meta(model_name, revision)
  • I have tested the implementation works on a representative set of tasks.

@Samoed Samoed requested review from KennethEnevoldsen and removed request for KennethEnevoldsen January 13, 2025 03:51
@Samoed
Copy link
Collaborator

Samoed commented Jan 13, 2025

Can you also fill information these model meta parameters?

  • public_training_data
  • public_training_code
  • training_datasets

@SamuelYang1
Copy link
Contributor Author

Can you also fill information these model meta parameters?

  • public_training_data
  • public_training_code
  • training_datasets

These model meta parameters have been filled.

Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge

mteb/models/inf_models.py Outdated Show resolved Hide resolved
@KennethEnevoldsen KennethEnevoldsen enabled auto-merge (squash) January 13, 2025 10:57
auto-merge was automatically disabled January 15, 2025 06:41

Head branch was pushed to by a user without write access

@Samoed Samoed enabled auto-merge (squash) January 15, 2025 06:54
@Samoed Samoed merged commit 60c4980 into embeddings-benchmark:main Jan 15, 2025
10 of 11 checks passed
@SamuelYang1 SamuelYang1 deleted the inf-retriever-v1 branch January 16, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants