Use file path to lint template #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydgruber
reviewed
Mar 13, 2021
| @@ -75,7 +75,7 @@ module.exports = { | |||
| if (node.quasi.type === 'TemplateLiteral') { | |||
| let hbs = node.quasi.quasis[0].value.cooked | |||
| hbs = unindentAndStripSafeNewlines(hbs) | |||
| const results = linter.verify({source: hbs.toString(), moduleId: context.id}) | |||
| const results = linter.verify({source: hbs.toString(), filePath: context.id, moduleId: context.id}) | |||
There was a problem hiding this comment.
Suggested change
| const results = linter.verify({source: hbs.toString(), filePath: context.id, moduleId: context.id}) | |
| const results = linter.verify({source: hbs.toString(), filePath: context.getFilename(), moduleId: context.id}) |
based on eslint docs, context.id seems like the wrong thing here.
There was a problem hiding this comment.
It's a shame this was merged without this fix; I just hit #40 as well and came to the same conclusion—context.id is just the rule name check-hbs-template-literals, which doesn't really make sense as the filePath or moduleId
|
I think this would resolve #40 w/ the suggested change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes error
The "path" argument must be of type string. Received type undefinedintroduced by this fix 🙈.fixes ember-template-lint/ember-template-lint#1161