Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vendor widevine library #240

Closed
wants to merge 4 commits into from

Conversation

dagwieers
Copy link
Collaborator

@dagwieers dagwieers commented Dec 22, 2019

This adds support for a vendor-supported Widevine library.

TODO:

  • Show actual version, not stored version
  • Update stored version
  • Get timestamp from library to show in info pane
  • Do not show Chrome OS information when using vendor library
  • Disable settings/operations

This fixes #229

@dagwieers dagwieers added this to the v0.5.0 milestone Dec 22, 2019
@dagwieers dagwieers force-pushed the vendor-widevine branch 10 times, most recently from ec9c521 to 5b62319 Compare December 23, 2019 02:40
@dagwieers
Copy link
Collaborator Author

The information pane will look like this:

Kodi information

  • Kodi version: 18.5
  • Kodi platform/architecture: Linux/arm

InputStream information

  • InputStream Helper version: 0.4.3
  • InputStream Adaptive version: 2.4.0

Widevine information

  • Widevine version: 4.10.1440.18 (supplied by vendor)

Please report issues to:

@dagwieers
Copy link
Collaborator Author

We need to test this functionality on Windows and macOS, mostly to test the behavior using hardlinking and exception handling.

@dagwieers
Copy link
Collaborator Author

@horstle Hardlinking here is not just useful to save disk space, but it makes testing if two files are the same file a lot more efficient than the worst case scenario: comparing complete content. Especially if this has to happen on every playback...

@horstle
Copy link
Collaborator

horstle commented Dec 23, 2019

I don't have any problem with (hard)links. I just prefer avoiding/minimising differences in behaviour on different platforms, but let's not start that discussion again.

@dagwieers
Copy link
Collaborator Author

@horstle Oh, I didn't want to start a polemic, I just found a better reason to use them (when they are supported)

@dagwieers
Copy link
Collaborator Author

@samnazarko Would it be useful to show the library timestamp as well in the information pane (i.e. ctime or mtime) so the user has an indication when the library was made/added?

@dagwieers dagwieers marked this pull request as ready for review December 23, 2019 20:06
@dagwieers dagwieers force-pushed the vendor-widevine branch 3 times, most recently from 0364556 to 1583ba5 Compare December 24, 2019 00:28
@samnazarko
Copy link

samnazarko commented Dec 24, 2019 via email

@dagwieers
Copy link
Collaborator Author

@samnazarko Without versioning information, how would users relate issues to versions/updates. Especially in the light of regressions (as have been reported in the past).

@samnazarko
Copy link

samnazarko commented Dec 24, 2019 via email

@samnazarko
Copy link

I've emailed through our current Widevine package.

This adds support for a vendor-supported Widevine library.
@dagwieers
Copy link
Collaborator Author

I had to rework this PR for a big code restructure and prefered to start from scratch while keeping the original branch. So there is now a new PR #311 with the necessary changes for vendor widevine support.

Most of the non-vendor related changes in this PR were recently merged as part of #310

And we can close this one.

@dagwieers dagwieers closed this Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support vendor distributed Widevine
3 participants