Deprecate --cache command line flag
#23415
Draft
+1
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag was already removed back in 2020 (emscripten-core#11094) and then restored again a year later in emscripten-core#13954. This change doesn't remove the flag, only deprecates it. Hopefully this was we can give folks plenty of time to stop using it. See emscripten-core#23284
sbc100
force-pushed
the
cache_argument
branch
from
4d0c939 to
b6fdc5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag was already removed back in 2020 (#11094) and then restored again a year later in #13954.
The reason for the revert was the
--cachewas need in order to override theEM_CACHEset by emsdk.However, emsdk has since been fixed to avoid setting EM_CACHE at all: emscripten-core/emsdk#797.
I think this means there should no longer be any valid use cases for
--cacheso we should be able to at least deprecate it.This change doesn't remove the flag, only deprecates it.
I won't land this change until @juj can confirm that Unity no longer depends on passing
--cache.See #23284