modding HDZero PR #755 to revert to 5bit compatible OSD element positioning. #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly from https://github.com/iNavFlight/inav/pull/7668/files commit Notable changes: * And added missing functions to bitarray.h/.c, msp_serial.h/.c * Used "drivers/max7456_symbols.h" instead of "drivers/osd_symbols.h" * Used baudRates[portConfig->msp_baudrateIndex] instead of baudRates[portConfig->peripheral_baudrateIndex] Additional changes: serial: serialPortFunction_e now needs 32 bits How to use: In CLI, Set FUNCTION_HDZERO_OSD to the appropriate serial port: Eg. Assuming to use serial port 4, enter the following CLI commands to enable FUNCTION_HDZERO_OSD in EmuFlight Configurator 3.0.1: serial 3 65536 115200 115200 0 115200 save
This is because we changed the size of serialPortConfig_s.functionMask TODO: Add the peripheral_baudrateIndex entry to serialPortConfig_s ?
As per geoffsim, the HDZero VTX hardcodes thE baudrate at 115200. So No point making this configurable in EmuFlight As of now. We can bring back the configurability later on if needed
Emuflight does not implement vtx tables and that causes corruption on certain hdzero firmware. Everything seems smooth as Buttercake
nerdCopter
force-pushed
the
20231207_hdzero_port_can_be_uint32_but_still_revert_OSD
branch
from
04dc823 to
a46d729
Compare
nerdCopter
deleted the
20231207_hdzero_port_can_be_uint32_but_still_revert_OSD
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterAnalog:This PR Analog same
diff(i.e. same values forosd_***_pos):This PR HDZero wide positions:
