Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress (don't fix) compiler warnings for 3rd party libraries - STM32F4 and STM32F7 #978

Conversation

nerdCopter
Copy link
Member

@nerdCopter nerdCopter commented Feb 29, 2024

suppresses (does not attempt to fix 3rd party libraries):

./lib/main/STM32F4/Drivers/STM32F4xx_StdPeriph_Driver/src/stm32f4xx_spi.c: In function 'I2S_Init':
./lib/main/STM32F4/Drivers/STM32F4xx_StdPeriph_Driver/src/stm32f4xx_spi.c:426:7: warning: this condition has identical branches [-Wduplicated-branches]
  426 |     if((RCC->PLLCFGR & RCC_PLLCFGR_PLLSRC) == RCC_PLLCFGR_PLLSRC_HSE)
      |       ^
./lib/main/STM32F7/Drivers/STM32F7xx_HAL_Driver/Src/stm32f7xx_hal_uart.c: In function 'HAL_UART_Init':
./lib/main/STM32F7/Drivers/STM32F7xx_HAL_Driver/Src/stm32f7xx_hal_uart.c:251:5: warning: this condition has identical branches [-Wduplicated-branches]
  251 |   if(huart->Init.HwFlowCtl != UART_HWCONTROL_NONE)
      |     ^

ref: https://stackoverflow.com/a/76435158/2013805

@nerdCopter nerdCopter changed the title supress (don't fix) compiler warnings for 3rd party libraries - STM32F4 and STM32F7 suppress (don't fix) compiler warnings for 3rd party libraries - STM32F4 and STM32F7 Feb 29, 2024
@nerdCopter nerdCopter force-pushed the 20240229_supress_duplicate_branches_warnings_in_3rd_party_lib branch from a6c4fab to fc7288c Compare February 29, 2024 17:12
@nerdCopter nerdCopter marked this pull request as ready for review February 29, 2024 20:07
@nerdCopter nerdCopter merged commit 2284366 into emuflight:master Feb 29, 2024
6 checks passed
@nerdCopter nerdCopter deleted the 20240229_supress_duplicate_branches_warnings_in_3rd_party_lib branch February 29, 2024 20:13
@nerdCopter nerdCopter restored the 20240229_supress_duplicate_branches_warnings_in_3rd_party_lib branch June 26, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant