Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectNameResolverPlugin #40

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

robherba
Copy link
Contributor

@robherba robherba commented Aug 31, 2024

This PR does the following:

  • Adjusting the ProjectNameResolverPlugin.
  • Removing colons from alias definitions.
  • Add a custom loader for twig files.

Notes:

  • We might need to change the location of the custom loader, and we could think about renaming it.
  • Both the plugin and the custom loader were needed to fix the new way of including templates inside other Twig templates.

{% include "emulsify-ui-kit:placeholder" with { place_holder: "Placeholder Content" } %}

@robherba robherba self-assigned this Aug 31, 2024
@robherba robherba changed the base branch from develop to release-sdc-support August 31, 2024 06:27
@robherba robherba changed the title Webpack plugin ProjectNameResolverPlugin Aug 31, 2024
Copy link
Collaborator

@callinmullaney callinmullaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robherba This is working great! I agree we should probably adjust the name and location. Here is my suggestions:

  • Rename custom-loader.js to sdc-loader.js
  • Move to config/webpack

Copy link
Collaborator

@callinmullaney callinmullaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REALLY nice work on this task Roberto. This should now close out our feature-set for Emulsify Core 2.0. I'm going to get this merged into the release and prepped for publishing today 🎉

Copy link

github-actions bot commented Sep 3, 2024

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants