Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cores/clock/intel: add reset to Intel PLLs #2139

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

piotro888
Copy link
Contributor

self.reset is not connected in IntelClocking PLLs.
I think it was simply missed, or is there some reason for it?

It makes declared reset input in some current Intel board definitions not effective (like here) and soc_rst that works via CRG ignored.

@enjoy-digital
Copy link
Owner

Thanks @piotro888, have you tested reboot command in the BIOS with this PR? If so and working, this could indeed be merged.

@piotro888
Copy link
Contributor Author

BIOS reset hangs up the SoC. I only tested external reset before, thanks!
I will check if workarounds from Xilinx clocking to delay the reset or anding locked with ~reset would solve this issue

@enjoy-digital
Copy link
Owner

@piotro888: Thanks for the feedback, that's possible the reset was not present for this reason, but spending enough time lookng at it should allow finding a proper solution.

@piotro888
Copy link
Contributor Author

piotro888 commented Dec 18, 2024

add_reset_delay adapted from Xilinx clocking fixed the BIOS reboot issue

@enjoy-digital
Copy link
Owner

Great, thanks a lot @piotro888! Let's merge then.

@enjoy-digital enjoy-digital merged commit a6bdbed into enjoy-digital:master Dec 18, 2024
@piotro888
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants