backwards compatibility with python3.7 #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayjaby
force-pushed
the
backwards_compatibility_python3.7
branch
from
9f5c3d0 to
3601b71
Compare
|
Thanks @dayjaby, this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2117 broke my linux-on-litex-vexriscv build as the f4pga conda environment still uses python3.7 and the new (python3.8) assignment expression got used in
if specific_div_range := getattr(self, f"clkout{n}_divide_range", None):.For the sake of backwards compatibility, and not unnecessarily breaking the build for other people, this PR gets rid of the assignment expression.
Edit: Same issue with building versa_ecp5 in linux-on-litex-vexriscv as the nextpnr-ecp5 install (
conda install litex-hub::yosys litex-hub::nextpnr-ecp5) requires python>=3.7,<3.8 but some script is using the python3.9's str removesuffix method.