Skip to content

Commit

Permalink
dfp: Add a feature to disable DNS query timeout (#38067)
Browse files Browse the repository at this point in the history
This PR adds a feature to disable the Envoy DNS query timeout and use
the underlying DNS implementation timeout by setting
`DnsCacheConfig.dns_query_timeout` to 0.

Risk Level: low
Testing: unit and integration test
Docs Changes: inline
Release Notes: inline
Platform Specific Features: dfp

---------

Signed-off-by: Fredy Wijaya <[email protected]>

Mirrored from https://github.com/envoyproxy/envoy @ e3246a555ad2b5b25139362deb8f5a35ba1682fe
  • Loading branch information
update-envoy[bot] committed Jan 22, 2025
1 parent 3444077 commit f299843
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,9 @@ message DnsCacheConfig {
// The timeout used for DNS queries. This timeout is independent of any timeout and retry policy
// used by the underlying DNS implementation (e.g., c-areas and Apple DNS) which are opaque.
// Setting this timeout will ensure that queries succeed or fail within the specified time frame
// and are then retried using the standard refresh rates. Defaults to 5s if not set.
google.protobuf.Duration dns_query_timeout = 11 [(validate.rules).duration = {gt {}}];
// and are then retried using the standard refresh rates. Setting it to 0 will disable the Envoy DNS
// query timeout and use the underlying DNS implementation timeout. Defaults to 5s if not set.
google.protobuf.Duration dns_query_timeout = 11 [(validate.rules).duration = {gte {}}];

// Configuration to flush the DNS cache to long term storage.
config.common.key_value.v3.KeyValueStoreConfig key_value_config = 13;
Expand Down

0 comments on commit f299843

Please sign in to comment.