Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/phoebus-olog: use FerretDB intead of MongoDB #232

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

minijackson
Copy link
Collaborator

To prevent having to compile MongoDB, which requires a lot of resources

@minijackson minijackson marked this pull request as ready for review January 14, 2025 09:50
Copy link
Collaborator

@stephane-cea stephane-cea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice workaround! Thanks

@minijackson
Copy link
Collaborator Author

Oh wait, if we change database backend, users will need to migrate their data from MongoDB to FerretDB, I'll need to document that. I'll also move that into the breaking changes.

@stephane-cea
Copy link
Collaborator

OK

I'll mark this pull request as a draft in the meantime.

@stephane-cea stephane-cea marked this pull request as draft January 14, 2025 13:38
@stephane-cea
Copy link
Collaborator

By the way, I just checked the known differences between MongoDB and FerretDB.

Something is drawing my attention:

document fields of double type must not contain Infinity, -Infinity, or NaN values.

update operations producing Infinity, -Infinity, or NaN are not supported.

Are we sure Olog isn't using any NaN? Because some PVs can hold NaN values...

@minijackson
Copy link
Collaborator Author

@stephane-cea Good question! I just checked, and it seems that Phoebus Olog only uses MongoDB to store attachments. Phoebus also doesn't currently seem to provide the option to send PV values in a log entry.

@stephane-cea
Copy link
Collaborator

In this case, I think it's safe to use FerretDB

Thanks for checking 👍

to prevent having to compile MongoDB,
which requires a lot of resources
@minijackson minijackson force-pushed the phoebus-olog-ferretdb branch from c59c3af to af8f170 Compare January 14, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants