New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #99

Merged

equinor-ruaj merged 34 commits into main from refactor-create-config-dict

Oct 16, 2024

Contributor

equinor-ruaj commented Sep 25, 2024 •

edited

Loading

Related to #78 #87

Remove or simplify multiple functions
Remove unused functions


          Simplify debug logging

841bd41

equinor-ruaj changed the title ~~Simplify debug logging~~ Refactor create_config_dict

equinor-ruaj added 16 commits

October 1, 2024 08:28


          Merge branch 'main' into refactor-create-config-dict

2ece89b


          Simplify method

988745b


          Move function used only for test fixture

06aae31


          Simplify method

6bfb3f6


          Remove unused import

1de9b55


          Remove get_help functionality

e57d4ac


          Simplify convert_table_2_sumo_file and convert_xtgeo_2_sumo_file

ad66e89


          Remove debug logging

b195741


          Remove test of removed function

d102818


          Move asserts to before function returns

653b10f


          Remove code asserts in favour of tests

a5f346a


          Remove deprecated argument

c6f8932


          Fix test_get_table to test what it says it does

5ade0b3


          Remove unused function

9f69d0e


          Organize imports

e9b7e69


          Run tests sequentially

fd2c303

equinor-ruaj force-pushed the refactor-create-config-dict branch from e36f3e6 to fd2c303 Compare

October 1, 2024 13:52

equinor-ruaj changed the title ~~Refactor create_config_dict~~ Refactoring

equinor-ruaj marked this pull request as ready for review

October 3, 2024 08:20

equinor-ruaj requested a review from a team

October 3, 2024 08:20

equinor-ruaj added 2 commits

October 8, 2024 10:24


          Simplify global dict specification

84af214


          Reduce debug logging

equinor-ruaj commented

View reviewed changes

src/fmu/sumo/sim2sumo/_special_treatments.py Show resolved Hide resolved

equinor-ruaj commented

View reviewed changes

src/fmu/sumo/sim2sumo/tables.py Show resolved Hide resolved

equinor-ruaj commented

View reviewed changes

src/fmu/sumo/sim2sumo/grid3d.py Show resolved Hide resolved

equinor-ruaj commented

View reviewed changes

src/fmu/sumo/sim2sumo/grid3d.py Show resolved Hide resolved

equinor-ruaj commented

View reviewed changes

src/fmu/sumo/sim2sumo/grid3d.py Show resolved Hide resolved


          Simplify test constants and remove verbose prints

ac2cd0f

equinor-ruaj force-pushed the refactor-create-config-dict branch from ea16dc4 to 13b9796 Compare

October 8, 2024 11:53


          Remove params that were always defaulted

1860f31

equinor-ruaj force-pushed the refactor-create-config-dict branch from 13b9796 to ed118ee Compare

October 8, 2024 12:21


          Remove verbose logging and some refactoring

ad3f33e

equinor-ruaj force-pushed the refactor-create-config-dict branch from ed118ee to ad3f33e Compare

October 8, 2024 12:34

equinor-ruaj added 6 commits

October 8, 2024 14:36


          Move sleep to after the action that makes the sleep necessary

1c3881e


          Simplify test assert

76804d6


          Remove deprecated ssdl block from test config files

4487b42


          Fix test warning could not auto detect case path

48324a2


          Add required info when setting content=property on grid3d metadata

cac6cb4


          Make printout after test ert run more readable

8a77c97

equinor-ruaj force-pushed the refactor-create-config-dict branch 2 times, most recently from dc22cb0 to f38c0bd Compare

October 10, 2024 08:47


          Separate test that runs ert to own file

2e33208

equinor-ruaj force-pushed the refactor-create-config-dict branch from f38c0bd to 2e33208 Compare

October 10, 2024 09:39

equinor-ruaj added 2 commits

October 10, 2024 11:45


          Simplify

e3da67e


          Fix typo

202ee30

equinor-ruaj force-pushed the refactor-create-config-dict branch from dfc2f43 to 202ee30 Compare

October 10, 2024 09:52

equinor-ruaj added 3 commits

October 10, 2024 12:11


          Simplify function return

67ad292


          Fix warning message

cfa2dec


          Remove logging

0db081c

equinor-ruaj mentioned this pull request

AttributeError when running sim2sumo #86

Closed

equinor-ruaj merged commit 3652356 into main

6 checks passed

equinor-ruaj deleted the refactor-create-config-dict branch

October 16, 2024 12:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet