[Feature] Add windows support #36
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindre-nistad
changed the title
sindre-nistad
force-pushed
the
feature/add-windows-support
branch
3 times, most recently
from
e0085da to
2c07f72
Compare
That way, we do not need to explicitly state which versions of Python we build for. It also simplifies some of the configuration It seems we need to explicitly include pybind11 directories for some builds
There are no pre-compiled wheels of scipy available for PyPy, so we run the tests with our own implementation of chi2 in pure Python
macOS 11 runners are no longer supported. Intel macs on GitHub Actions is now macOS 13.
It is only used in the build step Nor do we need to re-upload the files if cache was hit
`MKLConfig.cmake` may be located in different places (especially on Windows)
The Windows installer for Intel oneAPI (may) place `libiomp5md` in a different place than the rest of the libraries
MSVS uses a different convention for relevant options than GCC / LLVM. The paths from preprocessing are generally written using Windows-style directory separators (`\`), while CMake generally operates with UNIX-style separators (`/`)
sindre-nistad
force-pushed
the
feature/add-windows-support
branch
2 times, most recently
from
2fc140b to
a66cd09
Compare
sindre-nistad
force-pushed
the
feature/add-windows-support
branch
from
a52f0ee to
84ce12b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile, test and publish wheels for Windows.
Originally, this was attempted as part of #26, but I ran into trouble, hence making it a separate PR