Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add numpy builds #525

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add numpy builds #525

wants to merge 3 commits into from

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Jan 10, 2025 •
edited
Loading

Part of #6594

berland
berland reviewed Jan 10, 2025
View reviewed changes
komodo/release_transpiler.py

import yaml

from komodo.matrix import format_release, get_matrix
from komodo.prettier import load_yaml, write_to_file


def get_py_coords(release_base: str, release_folder: str) -> Sequence[str]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is hiding the fact that you are actually removing functionality (but the functionality seems unused, so it is warranted)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove test that only verifies presence of py tags in yaml-file

My apologies, I should have kept this as a draft PR, even though the issue is still in-progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berland berland berland left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreas-el @berland