Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Android app - Plugins - uses or overrides a deprecated API #1

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Fix for Android app - Plugins - uses or overrides a deprecated API #1

wants to merge 23 commits into from

Conversation

guyluz11
Copy link

@guyluz11 guyluz11 commented Jan 3, 2023

No description provided.

avioli added 22 commits April 28, 2021 10:25
@avioli
upgrade to null-safe platform_plugin_interface dep
735bb68
@avioli
let pub get do its thing
2a5131a
@avioli
extract linter rules from pedantic 1.11.0; remove pedantic dep
478841a
@avioli
add note where the base code is
27c3d5e
@avioli
add attribution
36434f0
@avioli
remove travis stats since config is too outdated
42c8fc8
@avioli
update readme to not null-safety API changes
e997af9
@avioli
update readmes to point to the pub page
feb20e2
@avioli
update to not-use pre-release sdk version; remove upper version bound…
22b1e1d 
… on flutter
@avioli
bump lower bound version of flutter as per pub publish note
5118b93
@avioli
allow catch-all filter with scheme-only
c910c09
@avioli
add note to only handle initial link once
4e770d4
@avioli
add malformed url example
954403e
@avioli
simplify example code to handle initial link only once; add malformed…
8cda6f3 
… example.

removed getInitialLink sample and tab bar
@avioli
let flutter update ios project
2aaec35
@avioli
add uni_links_web to the platforms list
80f5dda
@avioli
update changelog
6a59aed
@avioli
add screenshot how to add asscoriated domains capability in Xcode
b7e42f7
@avioli
add steps to add associated-domain capability via Xcode
4a9905f
@avioli
bump version to 0.5.0+2; update changelog
58cd78d
@avioli
bring back the metods to get the streams, but mark them as deprecated
a1d02ae
@avioli
version bump to 0.5.1
49d0569
tozu
tozu approved these changes Feb 6, 2023
View reviewed changes
Copy link

@tozu tozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(no one asked for a review, but i felt like doing one 😅)

LGTM, two small comments but nothing major :)

uni_links_platform_interface/pubspec.yaml Outdated
sdk: ">=2.12.0 <3.0.0"
flutter: ">=1.12.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix no new line at end of file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done Thanks

uni_links_web/.gitignore Outdated
@@ -0,0 +1 @@
.flutter-plugins-dependencies
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix no new line at end of file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, Thanks

guyluz11
guyluz11 commented Feb 6, 2023
View reviewed changes
Copy link
Author

@guyluz11 guyluz11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed request for changes

uni_links_platform_interface/pubspec.yaml Outdated
sdk: ">=2.12.0 <3.0.0"
flutter: ">=1.12.0"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done Thanks

uni_links_web/.gitignore Outdated
@@ -0,0 +1 @@
.flutter-plugins-dependencies
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tozu tozu tozu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guyluz11 @tozu @avioli