evm: de-duplicate bailout flag #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `ExecutionProcessor::call()` the bailout flag is passed by parameter but is also accessible as `evm().bailout`. It would be wrong if these flags are out of sync. Therefore, drop the bailout parameter and only use `evm().bailout` in the implementation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2653 +/- ##
==========================================
- Coverage 50.59% 50.57% -0.02%
==========================================
Files 784 784
Lines 52476 52476
Branches 8172 8172
==========================================
- Hits 26548 26540 -8
- Misses 23608 23613 +5
- Partials 2320 2323 +3 ☔ View full report in Codecov by Sentry. |
canepat
added
the
maintenance
canepat
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
ExecutionProcessor::call()the bailout flag is passed by parameter but is also accessible asevm().bailout. It would be wrong if these flags are out of sync. Therefore, drop the bailout parameter and only useevm().bailoutin the implementation.