Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - gcc 11 on PR workflow #2654

Merged
merged 1 commit into from
Jan 15, 2025
Merged

CI - gcc 11 on PR workflow #2654

merged 1 commit into from
Jan 15, 2025

Conversation

battlmonstr
Copy link
Contributor

Extra compilers find 2 types of problems:

  1. "lint" - warnings, style, adherence to standard C++ etc. These type of problems are typically found more by the latest compiler versions. They are usually not critical and easy to fix, so can be postponed to the master integration workflow.
  2. Usage of newer language and library features that are not available on old compiler versions. These type of problems are critical for GCC, because we make our releases (via silkworm-go) using the minimal GCC version. Such problems are not easy to fix as they might require reimplementing parts of the code without relying on the new features.

We shouldn't postpone critical and potentially hard work to the master integration workflow, therefore I suggest to use minimal compiler versions on the "light" PR workflow, and use other versions on "integration".

@battlmonstr battlmonstr requested a review from canepat January 14, 2025 08:17
@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Jan 15, 2025
@battlmonstr battlmonstr enabled auto-merge (squash) January 15, 2025 08:00
@battlmonstr battlmonstr merged commit 6b756da into master Jan 15, 2025
5 checks passed
@battlmonstr battlmonstr deleted the pr/gcc11light branch January 15, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants