Don't ignore the typescript definitions when packaging (#135) · esnet/pond@416b4a8 · GitHub

Commit

Don't ignore the typescript definitions when packaging (#135)

Browse files

Loading branch information

Mike-Dax authored and Peter Murphy committed Oct 14, 2019

1 parent 3e14a0c commit 416b4a8

.npmignore

-Original file line number
+Diff line change
@@ -1,4 +1,5 @@
     src
+    !src/index.d.ts
     test
     docs
     website
@@ Expand Down @@

6 comments on commit `416b4a8`

jpmjpmjpm commented on `416b4a8` Nov 7, 2019 •

edited

Loading

Thanks for this fix. Is there a way to install the pondjs package including this commit with npm install? What is the appropriate command if yes?

Contributor

pjm17971 commented on `416b4a8` Nov 7, 2019

I need to make a new npm release containing this. I was hoping to include another fix as well, but we'll see.

jpmjpmjpm commented on `416b4a8` Nov 7, 2019

Thanks for your (very!) quick response. Any idea of the timeframe for this new npm release?

Contributor

pjm17971 commented on `416b4a8` Nov 7, 2019

I published this as 0.9.0. Can you let me know if this causes any problems? I had to upgrade babel and although tests and my smoke test of this looked good, I could imagine something related to the transpiling not working now. I guess we'll see what breaks in the wild. Hence the rollback version is 0.8.10.

jpmjpmjpm commented on `416b4a8` Nov 7, 2019

I made basic tests... and it seems to work! In fact I'm using pondjs with react-timeseries-charts. Do you know any issues between react-timeseries-charts and pondjs 0.9.0?

Contributor

pjm17971 commented on `416b4a8` Nov 7, 2019

Shouldn’t be but let me know if you encounter anything.

Please sign in to comment.