Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radically simplify the generated Cargo.toml #243

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Conversation

ivmarkov
Copy link
Collaborator

I think it is time to radically simplify the generated template and ask only what toolchain folks want to use:

  • People routinely get confused with the embassy features -> make these mandatory in the generated Cargo.toml
  • People are attempting to do no_std with esp-idf-* - which is pointless -> remove the std and alloc features from the generated Cargo.toml

@ivmarkov ivmarkov requested a review from Vollbrecht October 26, 2024 22:56
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement in my opinion as it really simplifies the resulting cargo.toml, which was confusing some users due to the large amount of features.

@ivmarkov ivmarkov merged commit 76cd380 into master Nov 4, 2024
25 checks passed
@SergioGasquez SergioGasquez deleted the remove-no-std branch November 4, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants