Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Github CI for Risc-v targets #253

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Conversation

kaaax0815
Copy link
Contributor

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo fmt command to ensure that all changed code is formatted correctly.
  • I have used cargo clippy command to ensure that all changed code passes latest Clippy nightly lints.
  • My changes were added to the CHANGELOG.md in the proper section.

Pull Request Details 📖

The Github CI currently fails if the target is risc-v
See here and here

Description

  • Add rustfmt and clippy to components for nightly toolchain
  • Install ldproxy

Testing

In my own project kaaax0815/smart-hot-water-tank@204e20b

@kaaax0815 kaaax0815 marked this pull request as ready for review December 29, 2024 16:58
@ivmarkov
Copy link
Collaborator

Thanks!

@ivmarkov ivmarkov merged commit d06dc3c into esp-rs:master Dec 29, 2024
9 of 18 checks passed
@ivmarkov
Copy link
Collaborator

ivmarkov commented Dec 29, 2024

I'll update the changelog. It needs a new entry in "Fixed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants