Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(common): Created reusable actions for host and coverage tests (IDF-7856) #397

Merged
merged 1 commit into from
Nov 6, 2023
Merged

ci(common): Created reusable actions for host and coverage tests (IDF-7856) #397

merged 1 commit into from
Nov 6, 2023

Conversation

gabsuren
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gabsuren gabsuren force-pushed the feat/modem_reusable_actions branch from 7cf5660 to 104c5fd Compare October 23, 2023 16:49
@gabsuren gabsuren changed the title ci(common): Created reusable actions for host and coverage tests ci(common): Created reusable actions for host and coverage tests (ESP-IDFIDF-7856) Oct 23, 2023
@gabsuren gabsuren changed the title ci(common): Created reusable actions for host and coverage tests (ESP-IDFIDF-7856) ci(common): Created reusable actions for host and coverage tests (IDF-7856) Oct 23, 2023
@gabsuren gabsuren force-pushed the feat/modem_reusable_actions branch 2 times, most recently from a818d0f to 1879b33 Compare October 24, 2023 09:12
@gabsuren gabsuren marked this pull request as ready for review October 24, 2023 09:14
@gabsuren gabsuren requested a review from david-cermak October 24, 2023 09:15
david-cermak
david-cermak approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with few nitpicks

@gabsuren gabsuren force-pushed the feat/modem_reusable_actions branch 3 times, most recently from 9e16b39 to 2360f8a Compare November 2, 2023 14:00
@gabsuren gabsuren force-pushed the feat/modem_reusable_actions branch 5 times, most recently from cc3e652 to b3ed341 Compare November 6, 2023 10:35
@gabsuren gabsuren force-pushed the feat/modem_reusable_actions branch from b3ed341 to 9ad04de Compare November 6, 2023 15:15
@gabsuren gabsuren merged commit 0584da5 into espressif:master Nov 6, 2023
54 checks passed
@david-cermak david-cermak mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-cermak david-cermak david-cermak approved these changes

@euripedesrocha euripedesrocha euripedesrocha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gabsuren @CLAassistant @euripedesrocha @david-cermak @suren-gabrielyan-espressif