Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tls_cxx): Publish mbedtls-cxx component #509

Merged

Conversation

david-cermak
Copy link
Collaborator

@david-cermak david-cermak commented Feb 8, 2024

Move mbedTLS wrapper to public components

This is a draft, please look at the ideas and principles rather than coding/formal issues.

Task list:

  • Add documentation, README
  • Add CI jobs (at least build one), add label
  • Create a target test from the UART example
  • Move certs and keys to configs/environment
  • Move under espressif/idf namespace
  • Cleanup git history

components/mbedtls_cxx/mbedtls_wrap.cpp Outdated Show resolved Hide resolved
components/mbedtls_cxx/include/mbedtls_wrap.hpp Outdated Show resolved Hide resolved
components/mbedtls_cxx/mbedtls_wrap.cpp Show resolved Hide resolved
@david-cermak david-cermak force-pushed the feat/mbedtls_cxx_component branch from 17011dd to b103970 Compare March 15, 2024 09:40
@david-cermak david-cermak self-assigned this Mar 15, 2024
@david-cermak david-cermak force-pushed the feat/mbedtls_cxx_component branch 4 times, most recently from f5c7875 to d1a4355 Compare March 15, 2024 10:12
@david-cermak david-cermak marked this pull request as ready for review March 15, 2024 10:12
Copy link
Contributor

@AdityaHPatwardhan AdityaHPatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments related to examples, but otherwise the mbedtls cxx support looks good. thanks for adding the necessary support and examples.

@david-cermak david-cermak force-pushed the feat/mbedtls_cxx_component branch from 4c794bb to 03e87fd Compare April 3, 2024 09:40
@david-cermak
Copy link
Collaborator Author

@AdityaHPatwardhan Thanks for taking a look and for your comments and suggestions!

@euripedesrocha @gabsuren @alisitsyn @espressif-abhikroy Could you please have another look?

Adds examples and tests.
Also supports DTLS now.
0.1.0
Features
- Publish mbedtls component (0140455)
@david-cermak david-cermak force-pushed the feat/mbedtls_cxx_component branch from 03e87fd to 13793a8 Compare April 11, 2024 14:53
@david-cermak david-cermak merged commit bd6e120 into espressif:master Apr 11, 2024
124 of 135 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants