fix(mdns): add lock for some common apis (IDFGH-12338) #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chshu
approved these changes
Mar 13, 2024
zwx1995esp
force-pushed
the
fix/add_lock_for_mdns_common_api
branch
from
a0d11ad to
7a078e0
Compare
zwx1995esp
commented
Mar 13, 2024
zwx1995esp
force-pushed
the
fix/add_lock_for_mdns_common_api
branch
from
7a078e0 to
62823ef
Compare
|
Hi @david-cermak I wrapped the API |
github-actions
bot
changed the title
zwx1995esp
force-pushed
the
fix/add_lock_for_mdns_common_api
branch
5 times, most recently
from
33d9857 to
50a20dd
Compare
zwx1995esp
force-pushed
the
fix/add_lock_for_mdns_common_api
branch
from
50a20dd to
21c84bf
Compare
david-cermak
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a thread-safe risk, some common apis do not take a look when operate the static global variable
_mdns_serverof mdns.