Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The no_reset option is very useful for for doing passthrough updates as the reset functionality causes the passed-through board to not respond. I added the no_reset feature in the simplest way possible (just not calling reset()), though in future updates, feel free to change it.
Related
Fixes #178. Also, a partial fix for adafruit/Adafruit_WebSerial_ESPTool#321.
Testing
I tested this using a local version of https://github.com/adafruit/Adafruit_WebSerial_ESPTool. With this fix alone, it fails on the first attempt and then works on subsequent attempts. I will have another PR for that repo (related to our passthrough code) which makes it work consistently.
For hardware, I am using a Feather M4 and following the instructions in https://learn.adafruit.com/upgrading-esp32-firmware/upgrade-external-esp32-airlift-firmware-2.
Checklist
Before submitting a Pull Request, please ensure the following: