-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VSC-1546] fix version switch by persist sys python in idfSetup #1384
Open
brianignacio5
wants to merge
14
commits into
master
Choose a base branch
from
bugfix/version-switch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Download the artifacts for this pull request: |
Open
1 task
Fabricio-ESP
changed the title
fix version switch by persist sys python in idfSetup
[VSC 1546] fix version switch by persist sys python in idfSetup
Jan 3, 2025
Fabricio-ESP
changed the title
[VSC 1546] fix version switch by persist sys python in idfSetup
[VSC-1546] fix version switch by persist sys python in idfSetup
Jan 3, 2025
radurentea
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because ESP-IDF version now computes the virtual env python path from a
idf.pythonInstallPath
and current ESP-IDF version, there is an issue for v4.4.8 (uses embed Python 3.8) and v5.3.1 (use embed Python 3.11) calculates the wrong env path because this embed python is not persisted in idfSetup in extension global context. This leads to a wrong python env path calculated which failed the verification when showing the list of available IDF setups in the version switcher orESP-IDF: Configure ESP-IDF extension
command setup wizard.Fixes #1378
Type of change
Steps to test this pull request
ESP-IDF: Clear ESP-IDF Saved Setups
command.ESP-IDF: Configure ESP-IDF extension
to find existing ESP-IDF setup for v5.x.x. This will add this setup to the global extension context.ESP-IDF: Configure ESP-IDF extension
to find existing ESP-IDF setup for v4.4.x. This will add this setup to the global extension context.See that both ESP-IDF v5.3.1 and v4.4.8 are being shown in the list of existing setups in
ESP-IDF: Configure ESP-IDF extension
command setup wizard and status bar version switcher.See that both ESP-IDF v5.3.1 and v4.4.8 are being shown in the list of existing setups in
ESP-IDF: Configure ESP-IDF extension
command setup wizard and status bar version switcher.How has this been tested?
Manual testing as described above.
Test Configuration:
Checklist