Issue 663: add windows 2022 tests back #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggoneiESS
reviewed
Jan 8, 2025
There was a problem hiding this comment.
If I'm not mistaken, aren't the 2019 and 2022 blocks identical except for the use of vs2019 and vs2022? Why don't we add a variable in .github/workflows/set_env_vars.sh for 19 or 22 and then we can use the same block without having to change in future? Rather than using a False condition. That will also work for the future Vis Studio releases
|
Hi @ggoneiESS, we don't need windows 2019 anymore. I will remove them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It resolves #663 by adding windows 2022 tests back and updating conan dependences