Merge pull request #1590 from etalab/maintenance/rubocop

Maintenance rubocop
etalab · Jul 8, 2024 · 692763b · 692763b
2 parents 60c830b + d5ce65b
commit 692763b
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 2 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -3,6 +3,7 @@ require:
   - rubocop-rails
   - rubocop-capybara
   - rubocop-factory_bot
+  - rubocop-rspec_rails
 
 AllCops:
   NewCops: enable

diff --git a/Gemfile b/Gemfile
@@ -103,6 +103,7 @@ group :development do
   gem 'rubocop-rspec'
   gem 'rubocop-capybara'
   gem 'rubocop-factory_bot'
+  gem 'rubocop-rspec_rails'
 
   gem 'better_errors'
   gem 'binding_of_caller'

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -475,6 +475,9 @@ GEM
       rubocop-ast (>= 1.31.1, < 2.0)
     rubocop-rspec (3.0.2)
       rubocop (~> 1.61)
+    rubocop-rspec_rails (2.30.0)
+      rubocop (~> 1.61)
+      rubocop-rspec (~> 3, >= 3.0.1)
     ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
     sass-rails (6.0.0)
@@ -625,6 +628,7 @@ DEPENDENCIES
   rubocop-factory_bot
   rubocop-rails
   rubocop-rspec
+  rubocop-rspec_rails
   sass-rails (>= 6)
   sentry-rails
   sentry-ruby

diff --git a/spec/controllers/api/datapass_webhooks_controller_spec.rb b/spec/controllers/api/datapass_webhooks_controller_spec.rb
@@ -122,7 +122,7 @@
         it 'renders 422' do
           subject
 
-          expect(response).to have_http_status(422)
+          expect(response).to have_http_status(:unprocessable_content)
         end
       end
     end

diff --git a/spec/controllers/api/datapass_webhooks_v2_controller_spec.rb b/spec/controllers/api/datapass_webhooks_v2_controller_spec.rb
@@ -121,7 +121,7 @@
         it 'renders 422' do
           subject
 
-          expect(response).to have_http_status(422)
+          expect(response).to have_http_status(:unprocessable_content)
         end
       end
     end
-Original file line number
+Diff line change
@@ Expand Up / @@ -122,7 +122,7 @@ @@
             it 'renders 422' do
               subject
-              expect(response).to have_http_status(422)
+              expect(response).to have_http_status(:unprocessable_content)
             end
           end
         end
@@ Expand Down @@