Supprime les données de la session après envoi chez hubee #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbfeldis
force-pushed
the
supprime-les-données-de-la-session
branch
from
24b4768 to
b96eb88
Compare
JeSuisUnCaillou
approved these changes
Jun 18, 2024
| @@ -19,6 +19,7 @@ def send_qf | |||
| result = StoreQuotientFamilial.call(user: Current.user, identity: Current.pivot_identity, quotient_familial: Current.quotient_familial, recipient: hubee_recipient) | |||
|
|
|||
| if result.success? | |||
| reset_session | |||
There was a problem hiding this comment.
Si on peut mettre ça dans le ClearCurrentAttributes, ça peut simplifier le controller (je sais pas si c'possible, ni même si c'est un si bonne idée de lui donner cette responsabilité)
| Current.quotient_familial = "quotient_familial" | ||
| end | ||
|
|
||
| it "clears the user session" do |
There was a problem hiding this comment.
it doesn't clear the user session right now, only the Current's attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Les données de l'usager sont stockées en session le temps de faire sa demande, une fois celle-ci "validée" (actuellement après la création du télédossier chez HubEE mais d'ici après avoir ajouté une tâche de fond de création du télédossier) nous pouvons vider la session de l'usager.
Closes https://linear.app/pole-api/issue/API-3145/supprime-les-donnees-de-la-session-apres-envoi-chez-hubee