File name popover #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I add a dragend check to target
Highlight the corresponding header of monitored group when hovering
Append to target folder rather than append to target to prevent hierarchy confused
By applying counter on checking enter and leave, i solve the problems of dragenter and dragleave. It realizes the dragging resize function
Set transition at outer div
By class to check if monitored group is expanded , if so restore after dropping or ccollapse
Apply transition at mnt-folder-content rather than outer div
Check status by class
Set Light Mode as Default and remove unused package
Modify with correctly async/await
Rewrite mntfunc data function in delegation way and add target check to actuate it
Rewrite mntfunc folder function in delegation way
Rewrite mntstyle in delegation and add red color to notate droppable or not
Merge click check to mousedown to fix it cause drop not count as mouseup so click cannot be fired
Rewrite mntfold in delegation way abd improve it by adding a general counter
1. Reduce button bar area 2. Layout arrangement for fs-main 3. Remove <br> on each fs-data-label to increase density and select accuracy Remove testing data
Use different tints to differentiate normal options , submenu options and options in submenu
Work in process
Abandon style.width and style.height and apply with offsetWidth and offsetHeight. Because we need html data not css design data
Use clientWidth and clientHeight . Moreover, window.screen is invalid because of the limit of Electron, I cannot let contextmenu out of page without truncating
Auto search and remove visible status at every call of contextmenu
Replace display by visibility to solve problem. When use offset to get position if targeted element display is none it would be excluded to DOM tree (no rendering no offset)
Use getBoundingClientRect to get accurate parent offset
Detect dropmenu and visible class to turn off
Auto detect if there are data and MonitoredGroups folder or create ones
Although knowing that problem may result in execution order it still cannot figure out what is happen
Make a file-name-popover to show the file that have long file name
Give 0 when no data in db to prevent mntset.length is undefined
Move create db to dbBuild
Make code more readable and
…into Monitor-function
Check if clicked target is mnt-data to decide the timing of path jump
Add a header check before expanding in mntfold
Create database based on the name of monitored group
When drag monitored object into monitored group, auto detect if this group exist ,append it,or create one before append
Load monitored groups data when system is ready. Nevertheless, I decide to apply this feature in All and Shortcut only (perhaps i can add Favorite Group one day) out of performance consideration. Other monitored groups will be loaded once they are expanded , not removed with collapsing of course.
Merge monitored group highlight function into mntstyle
Add some test function to contextmenu to demonstrate the trigger
Split mntselected and mntcheck from other functions because of massive demands. Now mntselected would handle all selected related work like add selected tag, selected style ,remove selected tag, if target is selectiale expli gratia. mntcheck now handle all class type related work like if this target is belongs to xx class, this function is massively link to but not have to work with mntselected
Detecting if content is loaded function prevent from remove refreshing now solved
After reloading, monitored data's id are reassigned. It leads to a certain pass of duplicate check. To avoid it, I add exist check in database before duplicate node
Add mntspan function to adjust collapse behavior. However, it's better to give detect function to mntspan rather than check in person
Merge mntexpand to mntspan
Run mntspan after mntmain
Rewrite function for global context remove,submenu remove,hide option remove
Rewrite contextmenu function in delegation way by detecting function-section and call the corresponding contextmenu. Secondly, move to index-ux due to the globalization
Implement with array to realize dynamic function calling. I decide to keep this function at smaller scope to accept different main functions have their own selected style,mechanism and target acceptance. That's why I decide to call the corresponding function rather than unify them in ux
Merge all index-ux contextmenu related function
Return false when contextmenu is not exist. This would happen when click at invalid area and those function sections that contextmenu is not set up
Use a nested array dynamic function to handle different function section and different conditions. However, there is a bug in uxContextMenuRemove interrupt this function . hide setting should work after above function done
I create a new event call passcheck and bubble it. It is designed for afterward contextmenu related check . Because eventlistener is not traditional function, we cannot apply the concept of async/await on it. To mimic the behavior, the best way to achieve it is by dispachEvent.
hint function and long text name hidden function can't cooperate each other due to overflow-x/y issue.
|
Knowing issue about overflow-x and overflow-y |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.