-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Notebooks to bottom tabs #146
Conversation
How is the bottom sheet better than the side sheet? I'm not objecting per se, I'm just trying to understand what it's here to solve. |
From #106:
The bottom sheet is better because it's part of NoteListScreen so the notebook change is controlled by the screen.
I'm not a fan of a hierarchy view either, but we have a lot of other possibilities. I've been looking at the different Google apps on my phone (Calls, Messages, Photos, Drive…) and they all have different modern UIs that could be applicable to our use case: search-bar that shows categories when the search bar is focused (Messages), tabs for the different ways to browse the content (Photos), both (Calls and Drive). We just have to pick one we like.
I'm not sure what you mean. |
This is now based on #158 so should be merged after. Ready for review. |
It's conflicting now for whatever reason... I just merged #158 as requested. |
Ah I thought that it would work since they should have the same commits… I'll resolve the conflicts then. Yes we can make the text always show, I just thought it made it clearer which tab is active, since it's inexpensive to switch tabs to see the other labels. |
Rebased and ready to merge. I made the labels always show. |
This (among other things) would simplify the work on #106.
We now use the metadata of the notebooks: color and description.
Tested on web Firefox Linux
Tested on native Android