feat(contracts): Add deployment check for existing implementations #13721
+69
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: - Added implementation check in DeployImplementationsInput.salt() to prevent duplicate deployments - Added CREATE2 address computation to verify if contracts are already deployed - Added revert if implementations are already deployed with the given salt - Maintains backward compatibility by allowing deployment when no salt is provided - Improves deployment efficiency by preventing unnecessary redeployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added implementation check in
DeployImplementationsInput.salt()to prevent duplicate deployments of contracts. This change improves the deployment process by ensuring we don't unnecessarily redeploy contracts that are already deployed with the same salt.Key changes:
DeployImplementationsInput.salt()Tests
There is a file with tests for DeployImpelemtations.s.sol
packages/contracts-bedrock/test/opcm/DeployImpelemtations.s.sol
The tests cover all critical paths:
Additional context
This change addresses the TODO comment in
DeployImplementationsInput.salt()and improves deployment efficiency by preventing unnecessary redeployments. The implementation uses CREATE2 address computation to check for existing deployments, which is a gas-efficient way to validate deployment status.