Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kurtosis-devnet): user devnets #13728

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sigma
Copy link
Contributor

@sigma sigma commented Jan 13, 2025

Description

This change is an attempt at bridging the gap between kurtosis devnets
and future alphanet/betanet specification.
(see ethereum-optimism/devnets#4)

It does so by defining specific override points in a more generic
template.
Generic building blocks are defined in templates/, and rely on a new
"include" capability at the template level.
See foo-user.example.json for an example.

This approach might also provide a somewhat lighter entry point for
user devnet definitions, following the same principle.

Note that this is completely optional at this point, and the full
scope of the kurtosis definition is still available to whomever
needs/wants it.

Tests

Additional context

Metadata

This change is an attempt at bridging the gap between kurtosis devnets
and future alphanet/betanet specification.
(see ethereum-optimism/devnets#4)

It does so by defining specific override points in a more generic
template.
Generic building blocks are defined in templates/, and rely on a new
"include" capability at the template level.

This approach might also provide a somewhat lighter entry point for
user devnet definitions, following the same principle.

Note that this is completely optional at this point, and the full
scope of the kurtosis definition is still available to whomever
needs/wants it.
@sigma sigma requested a review from a team as a code owner January 13, 2025 14:43
@sigma sigma requested a review from geoknee January 13, 2025 14:43
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.85%. Comparing base (2fb8c66) to head (0cc49f4).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13728      +/-   ##
===========================================
- Coverage    47.25%   45.85%   -1.40%     
===========================================
  Files          958      901      -57     
  Lines        80075    75302    -4773     
  Branches       773      773              
===========================================
- Hits         37836    34530    -3306     
+ Misses       39335    38051    -1284     
+ Partials      2904     2721     -183     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 90.57% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 72 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants